Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few related changes:
GMP has a built-in extended GCD function, so we use it instead of the current one that's implemented at top-level, improving performance:
Before
After
gcdCoefficients(ZZ, RingElement)
andgcdCoefficients(RingElement, ZZ)
have now been defined, promoting the integer to appropriate ring just likegcd
.The documentation has been updated (converting to SimpleDoc, adding the new methods, and adding some examples).