Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to Simplicial Toric Varieties #3582

Open
wants to merge 227 commits into
base: development
Choose a base branch
from
Open

Improvements to Simplicial Toric Varieties #3582

wants to merge 227 commits into from

Conversation

mahrud
Copy link
Member

@mahrud mahrud commented Nov 15, 2024

This is on top of #3567, and hence also #3550.

Changes in Truncations

  • added test for truncation in presence of torsion
  • added support for partial multidegrees in basis'
  • added test for basis'
  • fixed caching in Truncations
  • added caching for coneFromVData(Matrix)
  • added test for basis' in Truncations
  • added temporary workaround for rawSelectByDegrees bug
  • added tests for basis in presense of torsion
  • fixed minor bug in basis with torsion degrees
  • fixed a couple of bugs in basis'

Changes in NormalToricVarieties

  • added isQQFano in NormalToricVarieties
  • cached isFano for NormalToricVariety
  • simplified classGroup and picardGroup for ToricMap
  • fixed a bug in picardGroup ToricMap
  • added test for classGroup and picardGroup for ToricMap
  • fixed a bug in inducedMap for simplicial toric varieties
  • changed vertices ToricDivisor to always return a matrix
  • fixed cohomology for simplicial toric varieties
  • added basis' as new basis strategy over toric varieties

@mahrud mahrud requested a review from ggsmith November 15, 2024 18:15
mahrud and others added 29 commits November 22, 2024 03:35
@mahrud
added hook for non-free maps in quotient & quotient'
165b363 
Also changed g \\ f to call quotient'(f, g) instead.
@mahrud
commented a few methods of \\
2331a04
@mahrud
updated docs for quotient and quotient'
67e2a49
@mahrud
changed BettiCharacters to use left factorization via \\
cd6b0b9
@mahrud
fixed a test based on the augmented form of \\
c842e52
@mahrud
added tests for quotient' for non-free maps
a664af1
@mahrud
separated ZZ and InexactField strategies for (quotient, Matrix, Matrix)
fececd7
@mahrud
added slight optimization for quotient and quotient'
2d96ad6
@Devlin-Mallory @mahrud
added length limits for connectingExtMap
65b995d
@mahrud
added method for truncating source of map more than target
dbc0c9d
@mahrud
fixed bug in prune for coherent sheaves on toric varieties
2cabe60
@mahrud
cached the output of nefGenerators
51d1710
@mahrud
cached variety of a ring in R.variety
88df62f
@mahrud
cached minimal presentation of SheafMap
298966f
@mahrud
preserved components after sheafification
30cda95
@mahrud
added check that rings of projective varieties are standard graded
af50a3c
@mahrud
added extra constructors for SheafMap
95c08e4
@mahrud
added isIsomorphic for CoherentSheaf and SheafMap
58f4486
@Devlin-Mallory @mahrud
changed "isIsomorphic" to prune rather than truncate, as discussed today
8fa584c
@mahrud
added SheafMap == SheafMap
07e08b1
@mahrud
improved global Ext of sheaves
0544a67
@mahrud
avoided minimization of truncations for sheaf map algorithms
182494a
@mahrud
added Complexes to dependencies of Varieties
0f51b3a
@mahrud
added yonedaSheafExtension
8a73de9
@Devlin-Mallory @mahrud
changed sheaf map composition, SheafMap == ZZ, and started connecting
040acc0 
homomorphism
@Devlin-Mallory @mahrud
added concatenation (| and ||) for sheaf maps
225f94f
@Devlin-Mallory @mahrud
fixed composition, homology, homomorphism, symmetricPower
d2b2c2e
@mahrud
moved sheaf map tests to tests-maps.m2
0a666ec
@mahrud
added test for isIsomorphism with timing
1035eb4
kellerlv and others added 28 commits November 22, 2024 03:38
@kellerlv @mahrud
Small documentation addition
f17d11d 
 ...
@Devlin-Mallory @mahrud
small fix to documentation
3cab22a
@Devlin-Mallory @mahrud
some changes to canonicalBundle
7f23f83
@Devlin-Mallory @mahrud
some changes; bug left to be fixed though
12ea63c
@mahrud
added HH^i(F(*)) to usage for cohomology
cc11f10
@Devlin-Mallory @mahrud
removed DegreeLimit in Hom, which causes issues in inverse
a6c7d28
@mahrud
temporarily disable SheafComplexes
8b3de82
@mahrud
bumped version of Varieties
82c516b
@mahrud
added test for truncation in presence of torsion
aff801a
@mahrud
added support for partial multidegrees in basis'
01f0ac9
@mahrud
added test for basis'
bb3fc42
@mahrud
fixed caching in Truncations
78a47de
@mahrud
added caching for coneFromVData(Matrix)
fc52de8
@mahrud
added isQQFano in NormalToricVarieties
1f6ff53
@mahrud
cached isFano for NormalToricVariety
83016b6
@mahrud
simplified classGroup and picardGroup for ToricMap
3c630f2
@mahrud
fixed a bug in picardGroup ToricMap
fbaeb47
@mahrud
added test for classGroup and picardGroup for ToricMap
0fe9fbb
@mahrud
fixed a bug in inducedMap for simplicial toric varieties
40488e9
@mahrud
changed vertices ToricDivisor to always return a matrix
ce24360
@mahrud
fixed cohomology for simplicial toric varieties
4176564
@mahrud
added basis' as new basis strategy over toric varieties
ab9f206
@mahrud
added test for basis' in Truncations
6a146c1
@mahrud
added temporary workaround for rawSelectByDegrees bug
2644292
@mahrud
added tests for basis in presense of torsion
032643d
@mahrud
fixed minor bug in basis with torsion degrees
d650557
@mahrud
fixed a couple of bugs in basis'
4de178a
@mahrud
fixed the documentation of vertices and latticePoints
a7adc8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggsmith ggsmith Awaiting requested review from ggsmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mahrud @Devlin-Mallory @kellerlv @johndcobb @DanielApsley