CCi #2537
Draft
CCi #2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some warning messages that should be fixed.
There were problems on implementing width, isEmpty, isMember, isSubset. Is the current output of toExternalString(RRi) correct?
now returns true if either real or imaginary is empty.
|
Would you like help with resolving the conflicts? I tried rebasing this on top of the development branch, except dropping the last two merge and revert commits, basically keeping the following commits:
I also added an empty Together, this seems to compile fine but the tests are still running here: Would you like me to force push to your branch so the tests can run on this PR? |
|
Looks like only one test failed, but I don't see why: -- testing Macaulay2/Core/basictests/D01.m2
Macaulay2/Core/basictests/D01.m2:4:54:(0):[4]: error: assertion failed
Macaulay2/Core/basictests/D01.m2:4:27:(0):[3]: --back trace--
Macaulay2/Core/basictests/D01.m2:4:1:(0):[2]: --back trace-- |
|
What is the status of this PR? cc: @MichaelABurr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating complex interval.