Combine Core alarm tests and skip them during "check"

[d-torrance]

As suggested in #1834 (comment).

[mahrud]

Do you mind also un-commenting these lines to see if this patch works?

M2/.github/workflows/test_build.yml

Lines 187 to 189 in 7f27a79

	# TODO: uncomment these when https://github.com/Macaulay2/M2/issues/1849 is fixed
	#./M2 -q --check 2 -e 'exit 0'
	#./M2 -q --check 3 -e 'exit 0'

(and remove the TODO line)

[d-torrance]

Do you mind also un-commenting these lines to see if this patch works?

M2/.github/workflows/test_build.yml

Lines 187 to 189 in 7f27a79

	# TODO: uncomment these when https://github.com/Macaulay2/M2/issues/1849 is fixed
	#./M2 -q --check 2 -e 'exit 0'
	#./M2 -q --check 3 -e 'exit 0'

(and remove the TODO line)

Sure thing!

[mahrud]

Sigh, Singular's website is down. Do you mind replacing the link for factory-4.2.0 in cmake/build-libraries.cmake with https://faculty.math.illinois.edu/Macaulay2/Downloads/OtherSourceCode/factory-4.2.0.tar.gz? I hope the checksum is the same.

[d-torrance]

Sigh, Singular's website is down. Do you mind replacing the link for factory-4.2.0 in cmake/build-libraries.cmake with https://faculty.math.illinois.edu/Macaulay2/Downloads/OtherSourceCode/factory-4.2.0.tar.gz?

Done!

I hope the checksum is the same.

It is:

profzoom@peg-amy:~/tmp$ wget https://faculty.math.illinois.edu/Macaulay2/Downloads/OtherSourceCode/factory-4.2.0.tar.gz
--2021-01-23 13:43:05--  https://faculty.math.illinois.edu/Macaulay2/Downloads/OtherSourceCode/factory-4.2.0.tar.gz
Resolving faculty.math.illinois.edu (faculty.math.illinois.edu)... 128.174.199.46
Connecting to faculty.math.illinois.edu (faculty.math.illinois.edu)|128.174.199.46|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 4271595 (4.1M) [application/octet-stream]
Saving to: ‘factory-4.2.0.tar.gz’

factory-4.2.0.tar.g 100%[===================>]   4.07M   604KB/s    in 6.7s    

2021-01-23 13:43:12 (619 KB/s) - ‘factory-4.2.0.tar.gz’ saved [4271595/4271595]

profzoom@peg-amy:~/tmp$ sha256sum factory-4.2.0.tar.gz 
b66c4c78847e24b71386a42ea2fb368b721f5cb03966c8c78801f1677c45e6c0  factory-4.2.0.tar.gz

[mahrud]

Thanks! Also, I forgot to mention you can use ${M2_SOURCE_URL}/factory-4.2.0.tar.gz instead. No need to push it now, maybe along with the next fix.

[DanGrayson]

Is this ready to be merged now?

[d-torrance]

Is this ready to be merged now?

I think so -- the cmake-ubuntu-latest-clang10 build worked, and the offending test was skipped as expected:

 -- capturing check(6, "Core")                                               -- 0.0320972 seconds elapsed
 -- capturing check(7, "Core")                                               -- 0.0352545 seconds elapsed
 -- skipping  check(8, "Core")                                               -- 0.000055801 seconds elapsed
 -- capturing check(9, "Core")                                               -- 0.0350842 seconds elapsed
 -- capturing check(10, "Core")                                              -- 0.0880943 seconds elapsed