Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show correct minimum version of flint in autoconf check #1844

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

d-torrance
Copy link
Member

We're actually checking for a minimum version of 2.6.3, but the
message was stating a lower bound of 2.7.0.

We're actually checking for a minimum version of 2.6.3, but the
message was stating a lower bound of 2.7.0.
@d-torrance
Copy link
Member Author

I was really confused as to why it was saying that >= 2.7.0 had been found during my build when only 2.6.3 was present!

I'm still puzzled as to why we're requiring factory 4.2.0 now. Everything was working fine for me with flint 2.6.x and factory 4.1.1. It seems like maybe the check should be a little more granular:

  • If both flint and factory are on the system, what are the minimum versions?
  • If only flint is on the system, what is the minimum version to build factory?
  • If neither are on the system, go ahead and build 2.7.0 and 4.2.0.

@mahrud
Copy link
Member

mahrud commented Jan 20, 2021

In general, I think it's fair to require that for building Macaulay2 from source you must have the latest version of all the requirements, and if not we will build them. For distributions, however, the packaged Macaulay2 may only use the latest version available on the distribution.

@DanGrayson
Copy link
Member

If it works fine with factory 4.1.1, and that's all that's available under Debian, then indeed, why not use it? Should I relax that check?

@DanGrayson DanGrayson merged commit ba1022b into Macaulay2:development Jan 20, 2021
@d-torrance
Copy link
Member Author

If it works fine with factory 4.1.1, and that's all that's available under Debian, then indeed, why not use it? Should I relax that check?

That would be great! Everything works at least as far back as 4.1.0, which is what's in Ubuntu 18.04.

@DanGrayson
Copy link
Member

done in commit ef1ebde

@d-torrance d-torrance deleted the flint-version-message branch May 26, 2021 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants