Skip to content
This repository has been archived by the owner on May 3, 2023. It is now read-only.

Automatically check for missing DLLs on Windows #160

Merged
merged 6 commits into from
Jan 1, 2022

Conversation

lithomas1
Copy link
Contributor

@lithomas1 lithomas1 commented Oct 26, 2021

closes #150

Merge for 1.4, since a rc would catch any problems here. This is a blocker since the Windows 2016 image is going away next year.

DLLS aren't checked on 32 bit since I cannot find a 32-bit python image on windows.

cc @simonjayhawkins

* Update windows.yml

* Update azure-pipelines.yml

* Syntax error?

* Update azure-pipelines.yml

* Temp revert this to see if CI picks it up and fails as expected

* Update azure-pipelines.yml

* Update azure-pipelines.yml

* Update azure-pipelines.yml

* Update azure-pipelines.yml

* Update azure-pipelines.yml

* Update azure-pipelines.yml

* Update azure-pipelines.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update azure-pipelines.yml

* Update windows.yml

* Update windows.yml

* Update azure-pipelines.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update azure-pipelines.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Update windows.yml

* Create check_windows_dlls.sh

* Update windows.yml

* Update windows.yml

* Update check_windows_dlls.sh

* Update windows.yml

* Update windows.yml

* Update and rename check_windows_dlls.sh to check_windows_dlls.bat

* Update windows.yml

* Update check_windows_dlls.bat

* Update check_windows_dlls.bat

* Update check_windows_dlls.bat

* Update windows.yml

* [skip ci] un comment code

* [skip ci] remove comments
@lithomas1 lithomas1 changed the title Automatically check for missing DLLs Automatically check for missing DLLs on Windows Oct 26, 2021
@simonjayhawkins
Copy link
Collaborator

Thanks @lithomas1

Merge for 1.4, since a rc would catch any problems here.

We don't have separate branches for 1.3.x and master in this repo (numpy does)

Can't we check the nightlies? (which are built from master)

On the last minor release cycle, 1.3rc was released before 1.2.5 (we can't guarantee that won't happen again)

@lithomas1
Copy link
Contributor Author

Can't we check the nightlies? (which are built from master)

We can, but I don't have a clean Windows environment(my laptop has MSVC on it and is too old to run Docker containers).
We can also try merging this early for 1.3.5. 1.4 is less risk, since the DLL that was missing should be included with Python 3.8's files. I tested this manually by commenting out dlls, and the import did seem to fail without some DLLs, so it should work.

I'm not sure what to do about the lack of 32 bit images, though. Maybe we should open an issue on the main repo about dropping 32 bit support entirely?

@matthew-brett
Copy link
Contributor

Maybe we should open an issue on the main repo about dropping 32 bit support entirely?

Just for reference - this was the latest I know of from the Microsoft / Python folks about 32-bit : scipy/scipy#14316 (comment)

@jreback
Copy link
Contributor

jreback commented Jan 1, 2022

@lithomas1 can u rebase

@@ -0,0 +1,4 @@
python --version
pip install pytz six numpy python-dateutil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why six?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a dependency of python-dateutil.

@jreback jreback merged commit 263a9fb into MacPython:master Jan 1, 2022
@lithomas1 lithomas1 deleted the auto-check-dlls branch January 28, 2022 23:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically check for missing DLLS on windows
5 participants