-
Notifications
You must be signed in to change notification settings - Fork 21
Automatically check for missing DLLs on Windows #160
Conversation
* Update windows.yml * Update azure-pipelines.yml * Syntax error? * Update azure-pipelines.yml * Temp revert this to see if CI picks it up and fails as expected * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update azure-pipelines.yml * Update windows.yml * Update windows.yml * Update azure-pipelines.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update azure-pipelines.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Update windows.yml * Create check_windows_dlls.sh * Update windows.yml * Update windows.yml * Update check_windows_dlls.sh * Update windows.yml * Update windows.yml * Update and rename check_windows_dlls.sh to check_windows_dlls.bat * Update windows.yml * Update check_windows_dlls.bat * Update check_windows_dlls.bat * Update check_windows_dlls.bat * Update windows.yml * [skip ci] un comment code * [skip ci] remove comments
Thanks @lithomas1
We don't have separate branches for 1.3.x and master in this repo (numpy does) Can't we check the nightlies? (which are built from master) On the last minor release cycle, 1.3rc was released before 1.2.5 (we can't guarantee that won't happen again) |
We can, but I don't have a clean Windows environment(my laptop has MSVC on it and is too old to run Docker containers). I'm not sure what to do about the lack of 32 bit images, though. Maybe we should open an issue on the main repo about dropping 32 bit support entirely? |
Just for reference - this was the latest I know of from the Microsoft / Python folks about 32-bit : scipy/scipy#14316 (comment) |
@lithomas1 can u rebase |
@@ -0,0 +1,4 @@ | |||
python --version | |||
pip install pytz six numpy python-dateutil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why six?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a dependency of python-dateutil.
closes #150
Merge for 1.4, since a rc would catch any problems here. This is a blocker since the Windows 2016 image is going away next year.
DLLS aren't checked on 32 bit since I cannot find a 32-bit python image on windows.
cc @simonjayhawkins