forked from Azure/azure-powershell
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Policy cmdlets for mercury #382
Open
siddharth7
wants to merge
1
commit into
mercury_dev
Choose a base branch
from
users/sisi/mercury_policy
base: mercury_dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharth7
force-pushed
the
users/sisi/mercury_policy
branch
3 times, most recently
from
November 29, 2018 08:25
af5c8d9
to
1004233
Compare
siddharth7
force-pushed
the
mercury_dev
branch
from
December 20, 2018 07:16
ea3c132
to
b872eab
Compare
siddharth7
force-pushed
the
users/sisi/mercury_policy
branch
2 times, most recently
from
December 20, 2018 07:23
e40bec6
to
e8fde85
Compare
siddharth7
force-pushed
the
mercury_dev
branch
from
December 26, 2018 06:53
b872eab
to
1ac99e4
Compare
siddharth7
force-pushed
the
users/sisi/mercury_policy
branch
from
December 26, 2018 07:53
e8fde85
to
34db583
Compare
siddharth7
commented
Dec 31, 2018
/// <summary> | ||
/// Is compression enabled | ||
/// </summary> | ||
public bool? IsCompression { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going forward we will have only one of these, resolve it now to avoid breaking changes
siddharth7
commented
Jan 8, 2019
{ | ||
SettingsBase settings = new SettingsBase(); | ||
settings.IsCompression = policySettings.IsCompression; | ||
settings.Issqlcompression = policySettings.Issqlcompression; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we keep only one of them?
siddharth7
force-pushed
the
mercury_dev
branch
from
January 8, 2019 06:11
1ac99e4
to
c437ebe
Compare
siddharth7
force-pushed
the
users/sisi/mercury_policy
branch
from
January 8, 2019 06:17
34db583
to
36511b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThrough
parameter.Cmdlet Parameter Guidelines