Week8 #9
Week8 #9
Conversation
| try { | ||
| await connectDB(process.env.MONGO_URI) | ||
| await Product.deleteMany() | ||
| await Product.create(jsonProducts) | ||
| console.log('Success!!!!') | ||
| process.exit(0) | ||
| } catch (error) { | ||
| console.log(error) | ||
| process.exit(1) | ||
| } |
There was a problem hiding this comment.
How would the program be different if this try / catch was not here?
| } | ||
| console.log(username, !password) | ||
| const id = new Date().getDate() | ||
| const token = jwt.sign({id, usernamen}, process.env.JWT_SECRET,{expiresIn: '30d'} ) | ||
|
|
||
| res.send('Fake login/register/signup Route') | ||
| }; | ||
|
|
||
| const dashboard = async (req,res)=>{ | ||
| const luckyNumber = Math.floor(Mathe.random()*100) |
There was a problem hiding this comment.
| } | |
| console.log(username, !password) | |
| const id = new Date().getDate() | |
| const token = jwt.sign({id, usernamen}, process.env.JWT_SECRET,{expiresIn: '30d'} ) | |
| res.send('Fake login/register/signup Route') | |
| }; | |
| const dashboard = async (req,res)=>{ | |
| const luckyNumber = Math.floor(Mathe.random()*100) | |
| } | |
| console.log(username, !password) | |
| const id = new Date().getDate() | |
| const token = jwt.sign({id, usernamen}, process.env.JWT_SECRET,{expiresIn: '30d'} ) | |
| res.send('Fake login/register/signup Route') | |
| }; | |
| const dashboard = async (req,res)=>{ | |
| const luckyNumber = Math.floor(Math.random()*100) |
I spy a typo!
Make sure you are testing your code always!!!!!!!!!!
|
|
||
| const dashboard = async (req,res)=>{ | ||
| const luckyNumber = Math.floor(Mathe.random()*100) | ||
| res.status(200).json({msg: `Hello, Mariana Osorio`, secret:`Here is your authorazied data, your lucky number is ${luckyNumber}`}) |
There was a problem hiding this comment.
| res.status(200).json({msg: `Hello, Mariana Osorio`, secret:`Here is your authorazied data, your lucky number is ${luckyNumber}`}) | |
| res.status(200).json({msg: `Hello, Mariana Osorio`, secret:`Here is your authorized data, your lucky number is ${luckyNumber}`}) |
nit: "authorized"
| const id = new Date().getDate() | ||
| const token = jwt.sign({id, usernamen}, process.env.JWT_SECRET,{expiresIn: '30d'} ) | ||
|
|
||
| res.send('Fake login/register/signup Route') |
There was a problem hiding this comment.
Are you having trouble at this point? Let me know if you have any questions – I think this assignment looks not totally complete because of this, but let me know if I'm missing something. This is the main reason I'm going to submit with status, "request changes," this week. Can we discuss if you're stuck here, and I can help you if that's the case?
Also, feel free to message me on slack, I'll be much quicker to respond!
| const authenticationMiddleware = async (req, res, next) => { | ||
| const authHeader = req.headers.authorization | ||
|
|
||
| if (!authHeader || !authHeader.startsWith('Bearer ')) { |
There was a problem hiding this comment.
Fun fact, just like in math class where you can factor values our of an expression by division;
4x + 6y -> (2x + 3y) * 2
You can always factor double-negatives out of boolean expressions. In this case, the simplified version is in my suggestion
| if (!authHeader || !authHeader.startsWith('Bearer ')) { | |
| if (!(authHeader && authHeader.startsWith('Bearer '))) { |
There was a problem hiding this comment.
Sometimes this refactor can make the expression easier to read. For example, in the second version, my mind very easily translates that into, "if there is not an auth header and the auth header starts with bearer." Which, more simply, is, "if there's not an auth header starting with Bearer ."
Anytime we're bringing the code closer to our own internal thoughts, we're making it more readable, which is great!
No description provided.