Skip to content

Commit

Permalink
Also push images on PRs to ease testing of PRs (#23)
Browse files Browse the repository at this point in the history
Fixes #9
  • Loading branch information
MaVdbussche authored Aug 16, 2024
1 parent 27194b1 commit 803c373
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/docker-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ env:

jobs:
build:
name: "Build the image and push it to ghcr.io"
runs-on: ubuntu-latest
permissions:
contents: read
Expand All @@ -38,7 +39,7 @@ jobs:
# Install the cosign tool except on PR
# https://github.com/sigstore/cosign-installer
- name: Install cosign
if: github.event_name != 'pull_request'
# if: github.event_name != 'pull_request'
uses: sigstore/[email protected]
with:
cosign-release: 'v2.2.4'
Expand All @@ -52,7 +53,7 @@ jobs:
# Login against a Docker registry except on PR
# https://github.com/docker/login-action
- name: Log into registry ${{ env.REGISTRY }}
if: github.event_name != 'pull_request'
# if: github.event_name != 'pull_request'
uses: docker/login-action@343f7c4344506bcbf9b4de18042ae17996df046d # v3.0.0
with:
registry: ${{ env.REGISTRY }}
Expand Down Expand Up @@ -94,7 +95,7 @@ jobs:
uses: docker/build-push-action@0565240e2d4ab88bba5387d719585280857ece09 # v5.0.0
with:
context: .
push: ${{ github.event_name != 'pull_request' }}
push: true # ${{ github.event_name != 'pull_request' }}
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
cache-from: type=gha
Expand All @@ -108,7 +109,7 @@ jobs:
# transparency data even for private images, pass --force to cosign below.
# https://github.com/sigstore/cosign
- name: Sign the published Docker image
if: ${{ github.event_name != 'pull_request' }}
# if: ${{ github.event_name != 'pull_request' }}
env:
# https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-an-intermediate-environment-variable
TAGS: ${{ steps.meta.outputs.tags }}
Expand Down
2 changes: 1 addition & 1 deletion .idea/misc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ docker run gluetun-helper:gluetun-helper
If you feel like you found a bug in the program, please raise an issue on GitHub.<br/>You can also use issues to request new features.

## License
This program is licensed under the [Apache License, Version 2.0](https://github.com/MaVdbussche/gluetun-helper/blob/master/LICENSE)
This program is licensed under the [Apache License, Version 2.0](https://github.com/MaVdbussche/gluetun-helper/blob/master/LICENSE)<br/>
This program uses the following dependencies:
- [OkHttp](https://square.github.io/okhttp/), licensed under the [Apache License, Version 2.0](https://square.github.io/okhttp/#license)
- [Gson](https://github.com/google/gson), licensed under the [Apache License, Version 2.0](https://github.com/google/gson/blob/main/LICENSE)

0 comments on commit 803c373

Please sign in to comment.