Fix flaky watchlist tests #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They failed because the locale was sometimes set to "de" and sometimes set to "en".
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #650 +/- ##
=======================================
Coverage 66.63% 66.64%
=======================================
Files 309 309
Lines 9384 9386 +2
=======================================
+ Hits 6253 6255 +2
Misses 3131 3131 ☔ View full report in Codecov by Sentry. |
7 tasks
fosterfarrell9
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watchlist tests relied on strings coming from Rails. Instead, we now just check if errors are present and if they contain the respective keys.
(I noticed that these tests are flaky in #647).