Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove emergency link #625

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Remove emergency link #625

merged 2 commits into from
Apr 24, 2024

Conversation

Splines
Copy link
Member

@Splines Splines commented Apr 22, 2024

As discussed in persona, the emergency is no longer needed as we don't think it will provide any benefit. The argument is that even motivated lecturer won't come up with a dedicated website tailored to help with specific content-related things in a video. Lecturers could link to the helpdesk service, but if this is offered in a semester, students will know this for sure through other communication channels. For students that have a specific question at a specific timestamp of a video, such an emergency link will probably never provide the tailored help they need. That's why we remove it here from the annotation tool.

For reviwers

The schema is updated in this PR via a new migration.

  • Please make sure that there are is no leftover code regarding the emergency link.
  • Students should still be able to create/edit annotations
  • Lecturers won't see the "edit emergency link" field in the settings of a lecture anymore

@Splines Splines self-assigned this Apr 22, 2024
@Splines Splines marked this pull request as ready for review April 22, 2024 21:59
Copy link
Collaborator

@fosterfarrell9 fosterfarrell9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Splines Splines merged commit 2b9e639 into dev Apr 24, 2024
5 checks passed
@Splines Splines deleted the feature/remove-emergency-link branch April 24, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants