Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign landing page #444

Merged
merged 34 commits into from
Apr 7, 2023
Merged

Redesign landing page #444

merged 34 commits into from
Apr 7, 2023

Conversation

Splines
Copy link
Member

@Splines Splines commented Apr 1, 2023 •
edited
Loading

Create a landing page that includes login options. Closes #231

image

With announcements

image

@Splines Splines self-assigned this Apr 1, 2023
@Splines Splines marked this pull request as ready for review April 1, 2023 12:35
fosterfarrell9
fosterfarrell9 requested changes Apr 1, 2023
View reviewed changes
Copy link
Collaborator

@fosterfarrell9 fosterfarrell9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new design. It looks fresher. Only the placement of the link for the locale still seems a little off to me.

config/routes.rb Outdated Show resolved Hide resolved
fosterfarrell9
fosterfarrell9 requested changes Apr 2, 2023
View reviewed changes
app/assets/images/landing-background.jpg Outdated Show resolved Hide resolved
config/routes.rb Show resolved Hide resolved
app/views/layouts/devise.html.erb Show resolved Hide resolved
@Splines
Make login padding to the right smaller
d292ed5 
This will allow the text
"Erinnere dich an mich (hierzu wird ein Cookie gesetzt)"
to be presented in one line on big screens.
@Splines
Show announcements at every state of landing screen
29723dd
@Splines
Remove round border of language switch on small devices
aad109b
@Splines
Copy link
Member Author

Splines commented Apr 3, 2023

@fosterfarrell9 Do we have a .env file for testing purposes? For example, the link to the blog is supposed to be located in such a file (see default_setting.rb). That's why on localhost, I get a link to localhost:3000 instead of https://mampf.blog.

@fosterfarrell9
Copy link
Collaborator

@fosterfarrell9 Do we have a .env file for testing purposes? For example, the link to the blog is supposed to be located in such a file (see default_setting.rb). That's why on localhost, I get a link to localhost:3000 instead of https://mampf.blog.

This is a bug. The environment variables are set in docker/development/docker-compose.yml, but BLOG_LINK is missing for some reason.

fosterfarrell9
fosterfarrell9 requested changes Apr 3, 2023
View reviewed changes
app/helpers/application_helper.rb Show resolved Hide resolved
app/views/layouts/devise.html.erb Outdated Show resolved Hide resolved
app/assets/images/landing-background.jpg Outdated Show resolved Hide resolved
app/views/layouts/devise.html.erb Outdated Show resolved Hide resolved
@Splines Splines merged commit 007a0ac into mampf-next Apr 7, 2023
@Splines Splines deleted the feature/login-screen-design branch April 7, 2023 16:11
@Splines Splines mentioned this pull request Apr 17, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fosterfarrell9 fosterfarrell9 fosterfarrell9 approved these changes

Assignees

@Splines Splines

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Splines @fosterfarrell9