Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small language improvements #34

Merged
merged 3 commits into from
Apr 23, 2023
Merged

Conversation

hungrywords
Copy link
Collaborator

Änderungsvorschläge mit Fokus auf Tense and Aspect bis Zeile 459

Fragen:
Warum Akzente statt richtigen Anführungszeichen (z.B. Z.9)?
imported_medium_invisible (Z.459ff.): zeitliche Abfolge?

Änderungsvorschläge mit Fokus auf Tense and Aspect bis Zeile 459

Fragen:
Warum Akzente statt richtigen Anführungszeichen (z.B. Z.9)?
imported_medium_invisible (Z.459ff.): zeitliche Abfolge?
@fosterfarrell9
Copy link
Collaborator

Die backticks z.B. in Z.9 besagen, dass es sich bei dem, was dazwischen steht, um einen Befehl handelt, und nicht um einen String, wie es bei Anführungszeichen der Fall wäre. Z.459ff passt so in der Überarbeitung.

@tynsh tynsh changed the base branch from master to mampf-next September 25, 2020 12:24
@CLAassistant
Copy link

CLAassistant commented Oct 16, 2020

CLA assistant check
All committers have signed the CLA.

@Splines Splines changed the title Tense and Aspect 1 Small language improvements Apr 21, 2023
@Splines
Copy link
Member

Splines commented Apr 21, 2023

I don't know what "aspects" are, so renamed this PR and added some small improvements.

@Splines Splines marked this pull request as ready for review April 21, 2023 22:12
@@ -26,7 +26,7 @@
# en:
# 'true': 'foo'
#
# To learn more, please read the Rails Internationalization guide
# For more information, please read the Rails Internationalization guide
# available at https://guides.rubyonrails.org/i18n.html.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the above was auto-generated by Rails ;-).

Copy link
Member

@Splines Splines Apr 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't have even touched these commented lines, but as they were already changed in this PR, I thought why not 🙈

@Splines Splines merged commit ab2b7b1 into MaMpf-HD:mampf-next Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants