Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixi for installation and execution #2

Merged
merged 10 commits into from
Dec 18, 2024

Conversation

fangohr
Copy link
Member

@fangohr fangohr commented Dec 10, 2024

Here is a pull request that introduces pixi for installation of the python tool. I have also added the tasks to the pixi.toml file, and documented this in the src/README.md.

Perhaps @santaep or @HoWilgh can try if this works if they follow the instructions.

If you are happy, do merge.

- chosen python 3.13 as this is most recent and seems to work
- no particular reason to stick to 3.13, but it is probably good to fix the
  version for improved reproducibility.
- when we release, it might be good to also commit the pixi.lock file to archive
  the precise set of libraries used.
Copy link
Contributor

@samjrholt samjrholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've successfully installed and run the first two tasks but get an error running the docs task

pixi.toml Outdated Show resolved Hide resolved
src/README.md Outdated Show resolved Hide resolved
@thomasschrefl
Copy link
Contributor

Looks good. I've successfully installed and run the first two tasks but get an error running the docs task

I do not where this error comes from. By the way in the meantime, I changed doc section of the create.sh script.
We should also update the pixi task accordlingy.

@fangohr
Copy link
Member Author

fangohr commented Dec 17, 2024

I fixed the error that Tom saw by merging the changes on the main branch into this PR.

@fangohr
Copy link
Member Author

fangohr commented Dec 18, 2024

This is ready to be merged, I think.

@fangohr fangohr requested a review from samjrholt December 18, 2024 09:01
@fangohr
Copy link
Member Author

fangohr commented Dec 18, 2024

We still have an error that occurs, but that has nothing todo with the addition of the pixi-based software installation or task execution: it also occurs on main when running the create.sh script.

With this merge request , we can and will do the build (equivalent to running create.sh) for every change to the repository, and that will tell us early if something is broken.

I have added a "badge" like this

build

to the README (at the very bottom for now) to quickly see the status.

@samjrholt are you happy for this to be merged?

@fangohr fangohr merged commit 076a3da into main Dec 18, 2024
0 of 2 checks passed
@fangohr fangohr deleted the pixi-for-installation-and-execution branch December 18, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants