Skip to content

Commit

Permalink
Remove question about version validation place
Browse files Browse the repository at this point in the history
In issue theupdateframework#1418 in this comment:
theupdateframework#1418 (comment)
I summarized the discussion we had with the participants in this issue.
In summary: no additional changes are needed for "version" validation
considering there is "bump_version()" function for that.

If we won't be adding "version" validation elsewhere we can keep it
the way it is.

Signed-off-by: Martin Vrachev <[email protected]>
  • Loading branch information
MVrachev committed Jun 1, 2021
1 parent d9a928e commit b39f198
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion tuf/api/metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,6 @@ def __init__(
self.spec_version = spec_version
self.expires = expires

# TODO: Should we separate data validation from constructor?
if version <= 0:
raise ValueError(f"version must be > 0, got {version}")
self.version = version
Expand Down

0 comments on commit b39f198

Please sign in to comment.