Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/business type in alerts #590

Merged
merged 16 commits into from
Nov 15, 2024
Merged

Conversation

Copy link
Contributor

@sandrica89 sandrica89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍

J'ai une question plus d'ordre fonctionnel, je l'ai mis sur le ticket.
Cela me fait aussi pas mal réfléchir au business type renseigné par le contrôleur lors de la création d'un contrôle 🤔

export const useTypographyStyles = makeStyles(theme => ({
fieldName: {
color: fr.colors.decisions.text.mention.grey.default,
fontSize: props => (props.uppercaseTitle ? "0.75rem" : "0.875rem")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Y'a pas des fontSize dans le DSFR ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

effectivement c'est une bonne question, oui apparemment
fr-text--xs: 12px
fr-text--sm: 14px
fr-text--md: 16px
fr-text--lg: 18px
fr-text--xl: 20px
ça vaudrait effectivement le coup de passer vers les classes dsfr

Copy link

sonarcloud bot commented Nov 15, 2024

@tristan-gueguen tristan-gueguen merged commit 3855f3a into master Nov 15, 2024
7 checks passed
@tristan-gueguen tristan-gueguen deleted the feat/business-type-in-alerts branch November 15, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants