-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/business type in alerts #590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good 👍
J'ai une question plus d'ordre fonctionnel, je l'ai mis sur le ticket.
Cela me fait aussi pas mal réfléchir au business type renseigné par le contrôleur lors de la création d'un contrôle 🤔
export const useTypographyStyles = makeStyles(theme => ({ | ||
fieldName: { | ||
color: fr.colors.decisions.text.mention.grey.default, | ||
fontSize: props => (props.uppercaseTitle ? "0.75rem" : "0.875rem") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Y'a pas des fontSize dans le DSFR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
effectivement c'est une bonne question, oui apparemment
fr-text--xs: 12px
fr-text--sm: 14px
fr-text--md: 16px
fr-text--lg: 18px
fr-text--xl: 20px
ça vaudrait effectivement le coup de passer vers les classes dsfr
Quality Gate passedIssues Measures |
https://trello.com/c/RoZMx5yL/1590-conception-tech-etq-contr%C3%B4leur-je-veux-savoir-quel-type-dactivit%C3%A9-a-%C3%A9t%C3%A9-pris-en-compte-lors-de-la-d%C3%A9termination-dune-alerte