Filtrer les emails non valides avant l'envoie #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolok
requested review from
etchegom and
syldb
and removed request for
a team
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
etchegom
reviewed
Nov 14, 2024
| invalid_emails = set(self.to_emails) - set(valid_to_emails) | ||
|
|
||
| if not valid_to_emails: | ||
| raise Exception("No valid recipient for email") |
There was a problem hiding this comment.
Suggested change
| raise Exception("No valid recipient for email") | |
| raise ValueError("No valid recipient for email") |
etchegom
reviewed
Nov 14, 2024
| @@ -25,6 +26,25 @@ def test_basic_send_transactional_email(self): | |||
| "email_param_value", | |||
| ) | |||
|
|
|||
| def test_send_transactional_email_no_emails_valid(self): | |||
| with pytest.raises(Exception, match="recipient for email"): | |||
There was a problem hiding this comment.
Suggested change
| with pytest.raises(Exception, match="recipient for email"): | |
| with pytest.raises(ValueError, match="recipient for email"): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description succincte du problème résolu
Erreur Sentry : https://sentry.incubateur.net/organizations/betagouv/issues/130638/?environment=production&project=29&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=14d&stream_index=5
Certain utilisateur n'ont pas d'email correct, on ignore ces emails et on log un wanning
Type de changement :
Auto-review
Les trucs à faire avant de demander une review :
.env.templateComment tester
En local / staging :