Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TNT for CTF #1284

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Add TNT for CTF #1284

wants to merge 20 commits into from

Conversation

farooqkz
Copy link
Contributor

@farooqkz farooqkz commented May 5, 2024

This PR aims to add TNTs to CTF, one of popular suggestions made by players.

  • TNT should be placed only near enemy flag
  • TNT shouldn't damage self or teammates
  • TNT shouldn't remove unremovable blocks
  • TNT sticks should be available in treasure chests
  • TNT recipe
  • TNT gives points for each block removed

@farooqkz farooqkz marked this pull request as ready for review May 5, 2024 15:41
@farooqkz
Copy link
Contributor Author

farooqkz commented May 5, 2024

This PR is ready to review. Though I cannot tell how to fix the remaining luacheck lints. There is one issue though:

When TNT explodes and removes blocks, it gives score to the owner according to the number of removed blocks. Like 70 removed blocks give 70 score. And since a TNT can only be placed near enemy base, this is the score for enemy base sabotage and/or destruction. However, 70 score seems too much to give away. Perhaps I divide the removed blocks number by something like... 5?

@AnonomousAccount
Copy link
Contributor

Does it damage players? IMO it should be used to remove blocks, not kill people. That's what nades are for

@AnonomousAccount
Copy link
Contributor

AnonomousAccount commented May 5, 2024

Also, IDK about awarding score...
Seems bad to offer an incentive for destruction

@LoneWolfHT
Copy link
Member

LoneWolfHT commented May 13, 2024

I'd rather not award score, and I'd like to keep the rules for placement as simple and non-restrictive as possible.

It would probably be best to restrict this change to nade fight at first

@farooqkz
Copy link
Contributor Author

farooqkz commented May 13, 2024

I'd rather not award score, and I'd like to keep the rules for placement as simple and non-restrictive as possible.

It would probably be best to restrict this change to nade fight at first

I'm in favor of awarding score as TNT can be placed only near an enemy base. And it is most likely enemy base destruction which is score-worthy and contributes to the goal of game which is CTF.

Edit:

But if you think 1 score per destroyed block is too much, we can reduce it to like 1/5 per block or even 1/10

@farooqkz
Copy link
Contributor Author

BTW, what do you think about adding a new stat: "Enemy base destruction". Could be number of blocks removed from the enemy base.

@AnonomousAccount
Copy link
Contributor

What count's as an "enemy base" tho, unfourtunatly, i can see how this could be exploited

@farooqkz
Copy link
Contributor Author

What count's as an "enemy base" tho, unfourtunatly, i can see how this could be exploited

Hello. It cannot be exploited since TNTs can be placed only close to enemy base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants