fix for non-pandas dataframe rendering #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #208 +/- ##
==========================================
- Coverage 80.82% 80.80% -0.03%
==========================================
Files 48 48
Lines 2493 2495 +2
==========================================
+ Hits 2015 2016 +1
- Misses 478 479 +1
Continue to review full report in Codecov by Sentry.
|
kafonek
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug in the conversion logic that ended up casting non-pandas DataFrames directly to pandas via
pd.DataFrame(obj)if they weren't the exact dtype that was being iterated over fromget_renderable_types()items. This resulted in some oddness like transposedpolarsdataframes.Update to the tests as well to make sure the number of rows and number of columns are different.