don't return private variables that match current dataframe #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shouples
changed the title
kafonek
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to match a dataframe to a variable name, if the only matches were private/auto-generated variables in the user namespace (e.g.
_1,_2, etc), it would return the most recent one. This would then go intouser_variable_namein the output metadata, which had unintended side effects. This PR returns theunk_dataframe_<hash>temporary internal dataframe name (for duckdb registration in the kernel session) instead.This also means any variable names starting with an underscore will be ignored and temporary variable names will be used internally instead.