Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extra sampling options #156

Merged
merged 2 commits into from
Jan 6, 2023
Merged

add extra sampling options #156

merged 2 commits into from
Jan 6, 2023

Conversation

shouples
Copy link
Collaborator

@shouples shouples commented Jan 6, 2023

resampling message now takes the following to pass into the settings_context to adjust row/column limitations and how truncating is done:

  • numColumns
  • rowSamplingMethod (default "random")
  • columnSamplingMethod (default "outer")

@codecov-commenter
Copy link

Codecov Report

Merging #156 (133e05f) into main (83690e2) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   80.18%   80.22%   +0.04%     
==========================================
  Files          48       48              
  Lines        2468     2473       +5     
==========================================
+ Hits         1979     1984       +5     
  Misses        489      489              
Impacted Files Coverage Δ
src/dx/filtering.py 100.00% <100.00%> (ø)
src/dx/types/filters.py 81.39% <100.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83690e2...133e05f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support new sampling UI fields during resampling (numColumns, rowSamplingMethod, columnSamplingMethod)
3 participants