Re-enable the octomap dependency. #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should now work by enabling the system dependency on octomap, rather than the one built-in to ROS 2 (which we'll be removing). Signed-off-by: Chris Lalancette <[email protected]>
clalancette
force-pushed
the
clalancette/re-enable-octomap-key
branch
from
544061c
to
14c0ee2
Compare
|
Awesome! I wasn't aware of that PR. Good move, IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed apps/libraries
This should now work by enabling the system dependency on octomap, rather than the one built-in to ROS 2 (which we'll be removing).
This is now possible because ros/rosdistro#41623 has been merged in.
If this is accepted, this should be backported to the branches supporting ROS 2 Jazzy, Iron, and Humble.
PR Description
I acknowledge to have:
CONTRIBUTINGpagedoc/source/doxygen-docs/changelog.mdto describe these changes (if applicable)AUTHORS(if applicable)(Notify: @MRPT/owners )