Skip to content

Commit

Permalink
fix(build): close tags in index.html (angular#3743)
Browse files Browse the repository at this point in the history
  • Loading branch information
CarreraPHP authored and MRHarrison committed Feb 9, 2017
1 parent b0e32c1 commit 46340fd
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
3 changes: 2 additions & 1 deletion packages/angular-cli/models/webpack-build-common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,8 @@ export function getWebpackCommonConfig(
template: path.resolve(appRoot, appConfig.index),
filename: path.resolve(appConfig.outDir, appConfig.index),
chunksSortMode: packageChunkSort(['inline', 'styles', 'scripts', 'vendor', 'main']),
excludeChunks: lazyChunks
excludeChunks: lazyChunks,
xhtml: true
}),
new BaseHrefWebpackPlugin({
baseHref: baseHref
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/scripts-array.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default function () {
.then(() => expectFileToMatch('dist/common-entry.bundle.css', '.common-entry-style'))
// index.html lists the right bundles
.then(() => expectFileToMatch('dist/index.html', oneLineTrim`
<link href="common-entry.bundle.css" rel="stylesheet">
<link href="common-entry.bundle.css" rel="stylesheet"/>
`))
.then(() => expectFileToMatch('dist/index.html', oneLineTrim`
<script type="text/javascript" src="inline.bundle.js"></script>
Expand Down
6 changes: 3 additions & 3 deletions tests/e2e/tests/build/styles/styles-array.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ export default function () {
.then(() => expectToFail(() => expectFileToExist('dist/renamed-lazy-styles.bundle.js')))
// index.html lists the right bundles
.then(() => expectFileToMatch('dist/index.html', oneLineTrim`
<link href="renamed-style.bundle.css" rel="stylesheet">
<link href="styles.bundle.css" rel="stylesheet">
<link href="common-entry.bundle.css" rel="stylesheet">
<link href="renamed-style.bundle.css" rel="stylesheet"/>
<link href="styles.bundle.css" rel="stylesheet"/>
<link href="common-entry.bundle.css" rel="stylesheet"/>
`))
.then(() => expectFileToMatch('dist/index.html', oneLineTrim`
<script type="text/javascript" src="inline.bundle.js"></script>
Expand Down

0 comments on commit 46340fd

Please sign in to comment.