Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#20 Upgrading to NH 4.1.x #21

Merged
merged 3 commits into from
Jan 10, 2017
Merged

Conversation

RogerKratz
Copy link
Contributor

Added assembly redirect in test project due to NH ref in FluentNHibernate

Added assembly redirect in test project due to NH ref in FluentNHibernate
@robdmoore
Copy link
Member

You also need to adjust the nuspec file (https://github.com/MRCollective/NHibernate.SqlAzure/blob/master/NHibernate4.SqlAzure/NHibernate4.SqlAzure.nuspec) to update the dependency the package has

@RogerKratz
Copy link
Contributor Author

Was a bit suprise to read
<<
A stable package release cannot have a pre-release dependency. This avoids accidentally installing a potentially unstable releases.

(https://docs.nuget.org/ndocs/create-packages/prerelease-packages)

Probably easier to wait for stable release then. If not, this lib has to be set to pre-release as well.

Updated the pull request so it's good-to-go when a NHib stable release of 4.1 has been made.

@RogerKratz
Copy link
Contributor Author

@robdmoore
NH 4.1 GA now released. This PR should be good-to-go now.

@RogerKratz
Copy link
Contributor Author

ping! Do you need any more changes to merge this one?

@nemenos
Copy link

nemenos commented Jan 9, 2017

I'm waiting for this pull request to be accepted too

@@ -4,5 +4,5 @@
<package id="EnterpriseLibrary.TransientFaultHandling.Data" version="6.0.1304.1" targetFramework="net45" />
<package id="Iesi.Collections" version="4.0.1.4000" targetFramework="net45" />
<package id="ilmerge" version="2.13.0307" targetFramework="net45" />
<package id="NHibernate" version="4.0.2.4000" targetFramework="net45" />
<package id="NHibernate" version="4.1.0-CR1" targetFramework="net45" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, looks like that's a pre-release version of NHibernate - not sure it's wise to publish a package that relies on a pre-release package - thoughts?

@robdmoore robdmoore merged commit 0ad3aae into MRCollective:master Jan 10, 2017
@robdmoore
Copy link
Member

Sorry peeps - had a new kid a couple of months back so been hectic :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants