replaces bad dispose #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! |
|
@MattEdwardsWaggleBee do you think that it should be that instead? |
|
@robdmoore That's the MSDN recommendation for a correct implementation of a derived Dispose, so yes. |
|
Seems reasonable to me! @npehrsson did you want to adjust the PR? |
|
Sure I can do it tomorrow
|
|
Pull request updated |
|
This is now on NuGet as 2.1.1. Thanks so much for the contribution! Sorry it took so long to get in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implemmentation is leaky if one do not cast the connection to a ReliableDbConnection before disposing.
This will fix that.