Lab 8 crc8 corrections #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added reset before going in busy state, otherwise crc_ff is not all 0 and we have wrong results deleted reset when entering idle state. reset there happens before ready signal from peripherial happens
Iweyka patch lab8
|
Здравствуйте! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added reset for crc_ff before going in busy state, otherwise we have errors in resulting crc8 (33 should convert into 5c not 55 like in current example). Also added picture because of this reason
Deleted reset for crc_ff when entering read state so our peripherial has time to set p_ready signal and read properly