Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional flags to pip install command #860

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

altheaden
Copy link
Collaborator

In this PR I added a few flags to the python -m pip install [-e] . command. The flags are:

  • -vv indicates very verbose output. This flag is used during the CI runs to help with debugging.
  • --no-deps indicates that pip should not install runtime dependencies from PyPi.
  • --no-build-isolation indicates that pip should not install build time dependencies from PyPi.

I also had to make several formatting changes to existing code in order to satisfy the linter.

Checklist

  • Developer's Guide has been updated
  • Documentation has been built locally and changes look as expected
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@altheaden altheaden added documentation Improvements or additions to documentation dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script labels Sep 23, 2024
@xylar
Copy link
Collaborator

xylar commented Sep 23, 2024

This looks good! I feel like the changes are significant enough that I'd better do a quick test, though.

@altheaden
Copy link
Collaborator Author

Sounds good, if you would like me to test it instead (or in addition) I would be happy to do so as well.

@xylar
Copy link
Collaborator

xylar commented Sep 23, 2024

Testing

I ran:

./conda/configure_compass_env.py --conda ~/chrysalis/miniforge3/ --verbose --recreate --env_name compass_test

As expected, I saw the new --no-deps and --no-build-isolation flags where we want them.

Then, just to make sure compass was installed properly, I ran:

source load_compass_test_chrysalis_intel_openmpi.sh
compass list

and saw the expected list of packages.

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@altheaden, excellent work as always. Thanks for taking care of the nasty linting!

@xylar
Copy link
Collaborator

xylar commented Sep 23, 2024

if you would like me to test it instead (or in addition) I would be happy to do so as well.

I don't think that's necessary. Just wanted to catch anything unexpected.

@xylar xylar merged commit 2e06f2e into MPAS-Dev:main Sep 23, 2024
5 checks passed
@altheaden altheaden deleted the pip-install-flags branch September 23, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants