Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tolerance on circ shelf decomp test #660

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Update tolerance on circ shelf decomp test #660

merged 1 commit into from
Aug 4, 2023

Conversation

matthewhoffman
Copy link
Member

@matthewhoffman matthewhoffman commented Aug 4, 2023 •
edited
Loading

This is required to allow circular shelf decomposition test to pass after updating version of Albany in #641. The differences are expected. Closes #654 .

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@matthewhoffman
Update tolerance on circ shelf decomp test
cf74639 
This keeps tests passing after updating version of Albany in MPAS-Dev#641
@matthewhoffman
Copy link
Member Author

Testing

Cherry-picking this commit onto #641 and running the full_integration suite, the circular shelf decomposition test validation now passes:

landice/circular_shelf/decomposition_test
  * step: setup_mesh
  * step: 1proc_run
  * step: 4proc_run
  test execution:      SUCCESS
  test validation:     PASS

@matthewhoffman matthewhoffman requested a review from xylar August 4, 2023 18:13
@matthewhoffman matthewhoffman self-assigned this Aug 4, 2023
xylar
xylar approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving by inspection. Looks reasonable. Please merge given your testing.

@matthewhoffman matthewhoffman merged commit e9a8b11 into MPAS-Dev:main Aug 4, 2023
@matthewhoffman matthewhoffman deleted the landice/update_circshelf_tol branch August 4, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xylar xylar xylar approved these changes

Assignees

@matthewhoffman matthewhoffman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation failures in circular_shelf
2 participants
@matthewhoffman @xylar