-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimum cmake for trilinos #549
Conversation
@trhille, this is the more permanent fix related to what I asked you to test in
as before. |
@xylar, I'm an error when I run this:
|
Okay, better leave this to me to debug. This method is way too slow. |
Thank you for being a good sport about a very tedious process. |
No problem! |
06581ad
to
ac13ad2
Compare
@trhille, these latest fixes are working for me on Chyrsalis. Could you give it another go? |
It probably doesn't make sense to build new spack environments for all machines and configurations because of this change. So far, there is still no change in compass dependencies that requires new spack environments. So I suggest we make this an "in progress" PR until we need it. |
@xylar, I'm sorry to say I'm getting an error when running this on Chicoma. The traceback is pretty heinous, but here are the bits that seem relevant:
|
AAAArgh! I don't think that piece of the stack trace is very helpful. I can give it a try myself... |
😞 |
@trhille, it worked fine for me. I deleted my |
Okay, I can try that as well. |
@xylar , okay I was able to run this successfully after removing my old spack_test and spack_temp directories! I'll set up and run |
Thanks @trhille. I ran into (and fixed) an issue I had with building the polaris environment on Chrysalis using the new environment without system cmake. I don't yet understand why my compass test didn't reveal the same issue but maybe it was just luck in terms for what was already in the environment I was testing. Anyway, it sounds like (assuming the |
All |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if it makes sense to approve a draft PR, but I'm doing so anyway!
I think this is a case where approving makes sense. Thanks, @trhille! |
Constrain to CMake >=3.23.0 as required by Trilinos.
f4249f6
to
9e8b196
Compare
Closing this because these changes are in #555 |
Checklist
Testing
in this PR) any testing that was used to verify the changes