-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deployment with latest conda (23.1.0) #545
Conversation
We need to update mamba before installing boa to prevent update failure.
TestingI installed a new Mambaforge with this code. I also used it on my existing Mambaforge installation. Both worked. |
@trhille and @mark-petersen, you both ran into this. Can you see if you are able to run @matthewhoffman, I don't know if you've run into this already but you likely will. |
This should stop things when there are errors, whereas previously deployment was plowing on even after things had gone wrong.
a73a0a5
to
95beb59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this works without any trouble, thanks! I tested on chicoma, chrysalis, and cori with
./conda/configure_compass_env.py --conda ~/miconda3 --compiler intel
or similar, and it created the load_dev_compass_1.2.0-alpha.4_chrysalis_intel_openmpi.sh
correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this on Perlmutter with the --with_albany
flag, using my existing miniconda3 and mambaforge installs, and both successfully created load_dev_compass_1.2.0-alpha.4_pm-cpu_gnu_mpich_albany.sh
.
One note is that when I used the mambaforge install, I got the following message upon sourcing the env load script, which I didn't get when using the miniconda3 install:
Loading Spack environment...
Inactive Modules:
1) cray-netcdf-hdf5parallel/4.9.0.1
Not sure what to make of the spack and cray-netcdf-hdf5parallel thing but that seems a coincidence. |
I merged this into another branch I'm working on for testing on perlmutter. Creating the new compass env worked successfully:
However, when I went to load the new env, I got a strange spack error:
Trying again with a clean environment (fresh login), loading the env works correctly, so the previous error must have been a spack environment collision and can be ignored.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on testing and casual inspection.
@matthewhoffman, yes, I suspect that It's looking for the environment in an incorrect location, perhaps because you previously loaded a different spack (corresponding to a different version of mache) in a different branch. It seems you can't simply switch spack environments by sourcing new load scripts. I don't think there's anything I can do about that. You need a fresh terminal for each branch or worktree you're using if they happen to use different spack locations. |
@mark-petersen, @trhille and @matthewhoffman, thank you for reviewing! |
It turns out that the
boa
package isn't compatible with the latestmamba
, but the latestmamba
is needed in order to use the latestconda
. So when compass tries to update everything, things end in a bad state. (An error message relate to a missingno_user
attribute occurs when runningmamba
.)The solution seems to be not to include
boa
in the base environment for now. This won't affect compass, sinceboa
is used to build conda packages and was just there for convenience (I sometimes need to build conda packages for compass maintenance).Checklist
Testing
in this PR) any testing that was used to verify the changescloses #544