Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find netcdf and pnetcdf with env vars on Chicoma and PM #531

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Feb 14, 2023

This is necessary because the nc-config executable (and equivalents for the other libraries) cannot be used to locate the correct path for the libraries relative to the bin directory.

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added the dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script label Feb 14, 2023
@xylar xylar requested a review from mark-petersen February 14, 2023 19:32
@xylar xylar self-assigned this Feb 14, 2023
This is necessary because the `nc-config` executable cannot be
used to locate the correct path for the libraries.
@xylar xylar force-pushed the fix_chicoma_deployment branch from ddf4cd3 to 6467964 Compare February 14, 2023 19:47
@xylar
Copy link
Collaborator Author

xylar commented Feb 14, 2023

Testing

With these changes, I am able to compile MPAS-Ocean on Chicoma and Perlmutter. Without them, the netcdf and pnetcdf libraries are not found (see #523 (comment)).

I also successfully ran the nightly test suite on Perlmutter. It is in the queue on Chicoma. Stay tuned...

@xylar
Copy link
Collaborator Author

xylar commented Feb 14, 2023

@mark-petersen, this is ready for you to try.

@xylar xylar mentioned this pull request Feb 15, 2023
1 task
@xylar xylar requested a review from darincomeau February 15, 2023 18:53
@xylar
Copy link
Collaborator Author

xylar commented Feb 15, 2023

@darincomeau and @mark-petersen, please cherry-pick this commit when you test #523

Copy link
Collaborator

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked for me on chicoma. Specifically, I started with the compass repo on #523, cherry-picked this commit, then:

rm -rf /lustre/scratch5/mpeterse/spack_test
rm -rf /lustre/scratch5/mpeterse/spack_tmp
export  CONDA_BASE=/usr/projects/climate/mpeterse/miconda3

./conda/configure_compass_env.py \
    --conda ${CONDA_BASE}  \
      --update_spack \
     --spack /lustre/scratch5/mpeterse/spack_test \
    --tmpdir /lustre/scratch5/mpeterse/spack_tmp  \
   --compiler gnu  \
   --recreate

note that I did not use

--mache_fork xylar/mache     --mache_branch update_cime_machines

, and this presumably defaults to

--mache_fork E3SM-Project/mache     --mache_branch main

Regardless, this finds the correct netcdf and pnetcdf paths on chicoma. I was able to compile with gnu debug and run a nightly test suite.

@xylar
Copy link
Collaborator Author

xylar commented Feb 17, 2023

@mark-petersen, thanks for testing!

and this presumably defaults to
--mache_fork E3SM-Project/mache --mache_branch main

No, that's not quite right. It defaults to getting mache from the latest release (from a conda package rather than the repository). So in the future you would need to explicitly put in that fork and branch to test with main, rather than the release. What you did is fine for testing this PR but doesn't test #523.

Copy link
Collaborator

@darincomeau darincomeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on testing with #523 on Perlmutter.

@xylar
Copy link
Collaborator Author

xylar commented Feb 17, 2023

Thanks @darincomeau!

@xylar xylar merged commit 99de7ba into MPAS-Dev:main Feb 17, 2023
@xylar xylar deleted the fix_chicoma_deployment branch February 17, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies and deployment Changes relate to creating conda and Spack environments, and creating a load script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants