Remove unused arguments to atm_set_smlstep_pert_variables_work #1227
Conversation
|
Note, I structured this PR so the final two commits (that deal with arguments to the main routine) can be dropped if those changes aren't desired. |
|
In my opinion, having five commits to remove unused arguments and variables may be unnecessary. I'd suggest we consider revising this PR so that it contains just two commits: one commit to make whitespace-only changes to executable code, and a second commit to remove unused arguments and variables (but without any reordering). |
Agreed. I will rebase to collapse these commits and update the PR description. |
gdicker1
force-pushed
the
atmosphere/smlstep_pert_reduce_args
branch
from
4436509
to
69f39a6
Compare
… routines The affected variables aren't used in any calculations within the atm_set_smlstep_pert_variables_work routine and can be safely removed.
gdicker1
force-pushed
the
atmosphere/smlstep_pert_reduce_args
branch
from
69f39a6
to
1f8ba37
Compare
|
@mgduda, please take another look. Despite the double force-push, the only changes are to the number of commits - no code changes. |
This PR removes unused arguments from the atm_set_smlstep_pert_variables_work and atm_set_smlstep_pert_variables routines.