Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant onClick handler from ProfileMenu #356

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

EdwardAngeles
Copy link
Contributor

@EdwardAngeles EdwardAngeles commented Nov 12, 2024

FP-2959: Toggle button is missaligned

@diasnad diasnad self-requested a review December 9, 2024 10:09
@manuelnogueiramov
Copy link
Contributor

How is removing an onClick listener fixing the alignment of the toggle?

@manuelnogueiramov
Copy link
Contributor

This is not only not "redundant" as it was causing this issue

This needs to be in the next release. @EdwardAngeles please coordinate this with @quirinpa so this ticket goes in the release

@manuelnogueiramov manuelnogueiramov merged commit 912ce59 into dev Dec 16, 2024
7 checks passed
@manuelnogueiramov manuelnogueiramov deleted the FP-2959-toggle-button-is-missaligned branch December 16, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants