Allow psql port etc and update for current Pandas #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for creating this tool!
After a fair amount of effort, I managed to get the MIMIC_Extract command:
make build_curated_from_psql
(in theutils
directory) to work. The key issues were:utils/setup_user_env.sh
expected the password as the first argument, but it was never called with an argument by the other scripts.)mimic_direct_extract.py
script to handle modern versions of Pandas.public
schema, butmimic_direct_extract.py
only looked inmimiciii
. So I have modified the code to change thesearch_path
to includepublic
.I'm sorry that this is a rather big patch; it would have been nicer to split it into separate patches, but I couldn't work on either part without fixing the other.