[pull] master from facebook:master #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Summary: Changelog: [Android][Added] - Basic definition for react gradle plugin Adds plugin and build configuration + copies config from react.gradle to extension. Copies internals of react.gradle to the plugin. Will be refactored in the next commits. Reviewed By: mdvacca Differential Revision: D25693008 fbshipit-source-id: b0feaa02cee8a1ee94d032426d19c501ff3b2534
Summary: Changelog: [Internal] Extracts task definition for bundling and hermes binary into separate tasks in the new plugin. Reviewed By: mdvacca Differential Revision: D25915057 fbshipit-source-id: b1d8a4b5e8789c3b7832efea13274435c9391ccb
Summary: Changelog: [Internal] - Use lazy task APIs in the Gradle new plugin Gradle now migrates to [lazy task APIs](https://docs.gradle.org/current/userguide/lazy_configuration.html) to help with project configuration time. It helps even in the rn-tester case, e.g. `./gradlew help` executes in 2-3s instead of 20s. The migration is quite simple - use `Provider` and `tasks.register` instead of `task.create` everywhere. Reviewed By: mdvacca Differential Revision: D25946748 fbshipit-source-id: 2ccd2f881afe7601e506dc7adcc8a658c7267328
Summary: The purpose of this change is to make TTRC markers work similarly for bridge loading and bridgeless loading so we could compare performance between them. There are mainly four cases involved: ```REACT_BRIDGE_LOADING_START, REACT_BRIDGE_LOADING_END, REACT_BRIDGELESS_LOADING_START, REACT_BRIDGELESS_LOADING_END ``` First 2 are for beginning/ending of bridge loading which includes creating fragment, loading JS bundle, running JS bundle and creating react instance. Last 2 are for similar purpose with bridgeless. Changelog: [Internal] Reviewed By: lunaleaps Differential Revision: D26514499 fbshipit-source-id: 65d6f3cc7de9e07a7a3a802dd77138e74c23aa5b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )