Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Navigation #174

Closed
wants to merge 35 commits into from
Closed

[WIP] Navigation #174

wants to merge 35 commits into from

Conversation

manyaagarwal
Copy link

@manyaagarwal manyaagarwal commented Jul 27, 2020 •
edited
Loading

Summary

  • Navigation for API and Component
  • Changed the way bookmarks work
  • Add bottom navigation bar component

To-do

Fixes #160
FIxes #172

Changelog

Implements navigation for the new design and changes how navigation reducer works

@manyaagarwal manyaagarwal added the RNTester The issues associated with the RNTester project. label Jul 27, 2020
chirag-singhal and others added 21 commits July 28, 2020 11:28
@chirag-singhal chirag-singhal linked an issue Jul 28, 2020 that may be closed by this pull request
Implement state based navigation #160
Closed
@YashKumarVerma YashKumarVerma linked an issue Jul 28, 2020 that may be closed by this pull request
Implement Bottom Navigation Component #172
Closed
@anku255
Copy link
Member

anku255 commented Aug 10, 2020

Closing it. The updated files are in mlh-fellowship-ui-changes branch.

@anku255 anku255 closed this Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@YashKumarVerma YashKumarVerma

@chirag-singhal chirag-singhal

@manyaagarwal manyaagarwal

Labels
RNTester The issues associated with the RNTester project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Bottom Navigation Component Implement state based navigation
4 participants
@manyaagarwal @anku255 @YashKumarVerma @chirag-singhal