Skip to content

Commit

Permalink
Fix lint rules in version 0.29 (facebook#1411)
Browse files Browse the repository at this point in the history
* Initial commit

* Issue facebook#1338 Removes version29 from alexignore

* Issue facebook#1338 V0.29 Corrects insensitive or inconsiderate language in version-29 of react native documentation

* Delete yarn.lock
  • Loading branch information
emilyannemoses authored and rickhanlonii committed Oct 19, 2019
1 parent 21229fa commit aaac5ae
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 12 deletions.
1 change: 0 additions & 1 deletion .alexignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ website/blog/
website/versioned_docs/version-0.16/
website/versioned_docs/version-0.18/
website/versioned_docs/version-0.22/
website/versioned_docs/version-0.29/
website/versioned_docs/version-0.43/
website/versioned_docs/version-0.46/
website/versioned_docs/version-0.53/
4 changes: 2 additions & 2 deletions website/versioned_docs/version-0.29/asyncstorage.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ title: AsyncStorage
original_id: asyncstorage
---

`AsyncStorage` is a simple, asynchronous, persistent, key-value storage system that is global to the app. It should be used instead of LocalStorage.
`AsyncStorage` is an asynchronous, persistent, key-value storage system that is global to the app. It should be used instead of LocalStorage.

It is recommended that you use an abstraction on top of `AsyncStorage` instead of `AsyncStorage` directly for anything more than light usage since it operates globally.

On iOS, `AsyncStorage` is backed by native code that stores small values in a serialized dictionary and larger values in separate files. On Android, `AsyncStorage` will use either [RocksDB](http://rocksdb.org/) or SQLite based on what is available.

The `AsyncStorage` JavaScript code is a simple facade that provides a clear JavaScript API, real `Error` objects, and simple non-multi functions. Each method in the API returns a `Promise` object.
The `AsyncStorage` JavaScript code is a facade that provides a clear JavaScript API, real `Error` objects, and non-multi functions. Each method in the API returns a `Promise` object.

Persisting data:

Expand Down
4 changes: 2 additions & 2 deletions website/versioned_docs/version-0.29/layout-props.md
Original file line number Diff line number Diff line change
Expand Up @@ -404,11 +404,11 @@ Setting `paddingVertical` is like setting both of `paddingTop` and `paddingBotto

### `position`

`position` in React Native is similar to regular CSS, but everything is set to `relative` by default, so `absolute` positioning is always just relative to the parent.
`position` in React Native is similar to regular CSS, but everything is set to `relative` by default, so `absolute` positioning is always relative to the parent.

If you want to position a child using specific numbers of logical pixels relative to its parent, set the child to have `absolute` position.

If you want to position a child relative to something that is not its parent, just don't use styles for that. Use the component tree.
If you want to position a child relative to something that is not its parent, don't use styles for that. Use the component tree.

See https://github.com/facebook/css-layout for more details on how `position` differs between React Native and CSS.

Expand Down
2 changes: 1 addition & 1 deletion website/versioned_docs/version-0.29/modal.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ title: Modal
original_id: modal
---

The Modal component is a simple way to present content above an enclosing view.
The Modal component is a way to present content above an enclosing view.

_Note: If you need more control over how to present modals over the rest of your app, then consider using a top-level Navigator. Go [here](navigator-comparison.md) to compare navigation options._

Expand Down
6 changes: 3 additions & 3 deletions website/versioned_docs/version-0.29/navigatorios.md
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ The default background color of the navigation bar.

### `interactivePopGestureEnabled`

Boolean value that indicates whether the interactive pop gesture is enabled. This is useful for enabling/disabling the back swipe navigation gesture.
Boolean value that indicates whether the interactive `pop` gesture is enabled. This is useful for enabling/disabling the back swipe navigation gesture.

If this prop is not provided, the default behavior is for the back swipe gesture to be enabled when the navigation bar is shown and disabled when the navigation bar is hidden. Once you've provided the `interactivePopGestureEnabled` prop, you can never restore the default behavior.

Expand Down Expand Up @@ -323,7 +323,7 @@ Go back N scenes at once. When N=1, behavior matches `pop()`.
pop();
```

Pop back to the previous scene.
`Pop` back to the previous scene.

---

Expand Down Expand Up @@ -424,7 +424,7 @@ Replaces the previous route/view and transitions back to it.
resetTo((route: object));
```

Replaces the top item and pop to it.
Replaces the top item and `pop` to it.

**Parameters:**

Expand Down
6 changes: 3 additions & 3 deletions website/versioned_docs/version-0.29/textinput.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ original_id: textinput

A foundational component for inputting text into the app via a keyboard. Props provide configurability for several features, such as auto-correction, auto-capitalization, placeholder text, and different keyboard types, such as a numeric keypad.

The simplest use case is to plop down a `TextInput` and subscribe to the `onChangeText` events to read the user input. There are also other events, such as `onSubmitEditing` and `onFocus` that can be subscribed to. A simple example:
An example use case is to plop down a `TextInput` and subscribe to the `onChangeText` events to read the user input. There are also other events, such as `onSubmitEditing` and `onFocus` that can be subscribed to.

```SnackPlayer
import React, { Component } from 'react';
Expand Down Expand Up @@ -185,7 +185,7 @@ If `true`, the text field will blur when submitted. The default value is true fo

### `defaultValue`

Provides an initial value that will change when the user starts typing. Useful for simple use-cases where you do not want to deal with listening to events and updating the value prop to keep the controlled state in sync.
Provides an initial value that will change when the user starts typing. Useful for use-cases where you do not want to deal with listening to events and updating the value prop to keep the controlled state in sync.

| Type | Required |
| ------ | -------- |
Expand Down Expand Up @@ -419,7 +419,7 @@ The highlight (and cursor on iOS) color of the text input.

### `value`

The value to show for the text input. `TextInput` is a controlled component, which means the native value will be forced to match this value prop if provided. For most uses, this works great, but in some cases this may cause flickering - one common cause is preventing edits by keeping value the same. In addition to simply setting the same value, either set `editable={false}`, or set/update `maxLength` to prevent unwanted edits without flicker.
The value to show for the text input. `TextInput` is a controlled component, which means the native value will be forced to match this value prop if provided. For most uses, this works great, but in some cases this may cause flickering - one common cause is preventing edits by keeping value the same. In addition to setting the same value, either set `editable={false}`, or set/update `maxLength` to prevent unwanted edits without flicker.

| Type | Required |
| ------ | -------- |
Expand Down

0 comments on commit aaac5ae

Please sign in to comment.