Record block execution time #128
Conversation
|
|
There was a problem hiding this comment.
I made some comments in the corresponding issue suggesting an alternative implementation that I think would be more extensible and useful in the long run, but I would not mind merging this as an interim solution while we do not decide and develop the final approach, as far as the comment about the Keras dependency is addressed.
setup.py
Outdated
| @@ -15,6 +15,7 @@ | |||
|
|
|||
|
|
|||
| install_requires = [ | |||
| 'Keras>=2.1.6,<2.4' | |||
There was a problem hiding this comment.
This should not be added here, since Keras is not a direct dependency of mlblocks.
Also note that current MLPrimitives master already fixed this problem.
There was a problem hiding this comment.
Updated the test dependency to use MLPrimitives master to fix this.
Also I apologize for the multiple commits/pushes, tests were passing just fine locally as they were using different versions of dependencies. I capped the issues that arise from newer versions.
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
+ Coverage 78.78% 79.45% +0.67%
==========================================
Files 5 5
Lines 707 735 +28
==========================================
+ Hits 557 584 +27
- Misses 150 151 +1
Continue to review full report at Codecov.
|
Resolve #127.