Allow selection of driver version and set 14ab2ff as current default #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn’t this be a command line option to the install script, not a config entry? |
ty-porter
force-pushed
the
driver-versioning
branch
from
854e374
to
f245995
Compare
|
Yeah we can default it in the installer. I think it's a little easier from end user's perspective to be able to put it into a config, but most people won't be tweaking that often, so this way is probably better long-term. |
Make the driver version a cmd line flag instead of config Update README driver text Actually do the checkout
ty-porter
force-pushed
the
driver-versioning
branch
from
f245995
to
04339a9
Compare
WardBrian
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.