Add final set of Datacite field methods #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: * Finish refactoring Datacite transform to use field methods How this addresses that need: * Add field methods and associated private methods for notes, publishers, related_items, rights, subjects, and summary * Add unit tests for new field methods Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TIMX-284
ehanson8
commented
May 31, 2024
ghukill
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Left a couple of suggestions, but nothing blocking from me. Looking good. And (pre)congrats on the first source in the books!
As mentioned, I think it's pretty exciting to see get_optional_fields() as a list of method calls, knowing this could very easily be refactored again (if decided we go that route) to a higher up calling context.
* Remove unnecessary list pattern from get_content_types, get_languages, and get_publishers methods * Refactor _get_description_notes method to remove unnecessary var and add description_type var * Refactor get_subjects method to use defaultdict
|
@jonavellecuerdo Pushed a new commit! |
jonavellecuerdo
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Finish refactoring
Datacitetransform to use field methods.How can a reviewer manually see the effects of these changes?
Run the following command to see that the
Datacitetransform still transforms a source file:Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Code Reviewer(s)