Update values for rights@kind=Access to Files #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: * Requested rights value changes from UXWS & EngX How this addresses that need: * Update get_rights method to use new value strings and corresponding unit tests * Update dependencies Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/GDT-247
ghukill
requested changes
Mar 27, 2024
There was a problem hiding this comment.
Reverting my approval based on this comment from Darcy that I missed: https://mitlibraries.atlassian.net/browse/GDT-247?focusedCommentId=126366.
Looks like we should downcase the new values, except MIT which can remain uppercase it sounds like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Value change requested by UXWS and EngX
How can a reviewer manually see the effects of these changes?
Observe updated values in unit tests
Includes new or updated dependencies?
YES
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Code Reviewer(s)