Expect single string URL for Aardvark dct_references_s #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: GeoHarvester will begin putting the external URL for MITAardvark records as a single string in the dct_references_s field, as opposed to an array of objects. How this addresses that need: * Expects the external URL as the direct value for key 'http://schema.org/url' Side effects of this change: * None; downstream records for TIM and Opensearch will look the same Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/GDT-68
9 tasks
ehanson8
approved these changes
Feb 7, 2024
jonavellecuerdo
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
GeoHarvester will begin putting the external URL for MITAardvark records as a single string in the
dct_references_sfield, as opposed to an array of objects as was formerly the case.Small change in where to look for this value, with the end result of the TIMDEX record unchanged.
How can a reviewer manually see the effects of these changes?
Tests do a good job of demonstrating the change.
Includes new or updated dependencies?
NO
Changes expectations for external applications?
YES - GeoHarvester has an associated PR: MITLibraries/geo-harvester#139
What are the relevant tickets?
Developer
Code Reviewer(s)