Linting update #116
Merged
Linting update #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update linting according to best practices described here https://mitlibraries.atlassian.net/wiki/spaces/IN/pages/3432415247/Python+Project+Linters
* Changes across the repo to satisfy or ignore linter errors
* Remove mistakenly added file
jonavellecuerdo
approved these changes
Jan 31, 2024
ghukill
requested changes
Jan 31, 2024
There was a problem hiding this comment.
All in all, heroic work here! Thanks for taking this on. The vast, vast majority to me looks outstanding. I can already tell that hopping into this codebase will be a bit more inviting now, given the increased typing and linting help.
I left a few optional suggestions, and would have marked this PR as approved with those as just suggestions, but the one I think warrants some discussion is the exception DeletedRecord vs DeletedRecordError (comment link).
That said, great work. Looking forward to getting this merged!
* Rename DeletedRecordError > DeletedRecordEvent * Rename lambda var attr > _ * Refactor MITAardvark.get_subjects() method
ghukill
approved these changes
Jan 31, 2024
| @@ -134,7 +134,7 @@ def validate_date_range( | |||
| return False | |||
|
|
|||
|
|
|||
| class DeletedRecordError(Exception): | |||
| class DeletedRecordEvent(Exception): # noqa: N818 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
The following documentation related error codes were ignored as they were numerous but did not affect application functionality:
Responded to most linter suggestions and placed 1 line ignores where the changes would compromise readability.
Declined to install type stubs for
BeautifulSoupas it introduced 168mypyerrors and this application has been running fine in prod for some time now.Includes new or updated dependencies?
YES
Changes expectations for external applications?
NO
Developer
Code Reviewer(s)