Update links handling for Aardvark transform #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: With updates to the structure of dct_references_s in GeoHarvester, Transmogrifier needs updates as well for parsing that JSON string. How this addresses that need: * Field method get_links() is updated to handle new url / website type in JSON string * Updating to http vs https for schema.org URIs to be consistent with other OGM metadata Side effects of this change: * Additional links in TIMDEX record Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/GDT-149
ehanson8
approved these changes
Jan 29, 2024
jonavellecuerdo
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpful background context
With updates to the structure of dct_references_s in GeoHarvester (PR), Transmogrifier needs updates as well for parsing that JSON string.
Updates:
get_links()is updated to handle new url / website type in JSON stringhttpvshttpsfor schema.org URIs to be consistent with other OGM metadataHow can a reviewer manually see the effects of these changes?
Changes are minor, updates in test shows how
linksfield is updated in outputted TIMDEX Record.What are the relevant tickets?
Developer
Code Reviewer
(not just this pull request message)
Includes new or updated dependencies?
YES | NO