Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holy heck this might work? #201

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Holy heck this might work? #201

wants to merge 7 commits into from

Conversation

JPrevost
Copy link
Member

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@mitlib mitlib temporarily deployed to timdex-ui-pi-bounding-b-m3qwcr October 29, 2024 20:23 Inactive
- bbox is sometimes in a different field (ticket opened to understand why)
- bbox sometimes has spaces and sometimes not so we handle both
- convert strings to floats during initial string extraction rather than during coords array creation
- if bbox_array is not 4 elements, don't use it
- if we don't have a record at all, don't try to use it
@JPrevost JPrevost temporarily deployed to timdex-ui-pi-bounding-b-m3qwcr October 30, 2024 15:04 Inactive
@coveralls
Copy link

coveralls commented Oct 30, 2024

Pull Request Test Coverage Report for Build 11596279055

Details

  • 14 of 17 (82.35%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 98.2%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/controllers/record_controller.rb 14 17 82.35%
Totals Coverage Status
Change from base Build 10390461913: -0.3%
Covered Lines: 600
Relevant Lines: 611

💛 - Coveralls

@JPrevost JPrevost temporarily deployed to timdex-ui-pi-bounding-b-m3qwcr October 30, 2024 15:19 Inactive
yes, I know the tests are failing too. It needs cassette regen but wanted to share the idea before tuning it up
@JPrevost JPrevost temporarily deployed to timdex-ui-pi-bounding-b-m3qwcr October 30, 2024 19:09 Inactive
@JPrevost JPrevost temporarily deployed to timdex-ui-pi-bounding-b-m3qwcr October 30, 2024 19:20 Inactive
@JPrevost JPrevost temporarily deployed to timdex-ui-pi-bounding-b-m3qwcr October 31, 2024 18:03 Inactive
@mitlib mitlib temporarily deployed to timdex-ui-pi-bounding-b-wmkutk November 5, 2024 18:34 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants