Fix iOS text wrap bug

[jazairi]

Why these changes are being introduced:

SwiftUI/iOS has some unusual behavior for list markers. It adds line height to them, such that when we increase the font size for a marker, the line height is dramatically increased. This is particularly visible when the text next to the marker wraps, which is common for TIMDEX UI record titles.

Relevant ticket(s):

• GDT-246

How this addresses that need:

This implements a CSS workaround. First, we reset the line height to 0 on .result, enforcing no line height for markers. Then, we add a div to wrap the rest of the result (.result-content), with a rule that sets the line height to 1.2.

Side effects of this change:

I don't forsee any, but it's a pretty ugly workaround to accommodate a minor bug in a weird OS.

Developer

Accessibility

• ANDI or WAVE has been run in accordance to our guide.
• This PR contains no changes to the view layer.
• New issues flagged by ANDI or WAVE have been resolved.
• New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
• No new accessibility issues have been flagged.

New ENV

• All new ENV is documented in README.
• All new ENV has been added to Heroku Pipeline, Staging and Prod.
• ENV has not changed.

Approval beyond code review

• UXWS/stakeholder approval has been confirmed.
• UXWS/stakeholder review will be completed retroactively.
• UXWS/stakeholder review is not needed.

Additional context needed to review

This will get UXWS review, but if the code reviewer would like to do QA as well, it would be useful to confirm the changes on a few browsers on desktop and on an iOS device.

Code Reviewer

Code

• I have confirmed that the code works as intended.
• Any CodeClimate issues have been fixed or confirmed as
  added technical debt.

Documentation

• The commit message is clear and follows our guidelines
  (not just this pull request message).
• The documentation has been updated or is unnecessary.
• New dependencies are appropriate or there were no changes.

Testing

• There are appropriate tests covering any new functionality.
• No additional test coverage is required.

[coveralls]

Pull Request Test Coverage Report for Build 9417800516

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 98.653%

---

Totals
Change from base Build 9321167366:	0.0%
Covered Lines:	586
Relevant Lines:	594

---

💛 - Coveralls

[JPrevost]

Interesting... I wonder if our "CSS reset" settings might be expanded to cover things like this without breaking things badly:
https://github.com/MITLibraries/mitlib-style/blob/master/_assets/sass/global/_unsets.scss

[jazairi]

Interesting... I wonder if our "CSS reset" settings might be expanded to cover things like this without breaking things badly: https://github.com/MITLibraries/mitlib-style/blob/master/_assets/sass/global/_unsets.scss

It would take some creativity. We might be able to do something like this:

li::before {
  line-height: 0
}
li::after {
  line-height: 1 /* or whatever */
}

[JPrevost]

I'm not sure I agree this is an improvement. I'll bring a conversation to slack tomorrow to make sure I understand what is changing and why and share what I am seeing to ensure we're seeing the same thing before we confirm if this addresses the problem

[jazairi]

@JPrevost Could you confirm that the two recently pushed commits address the issue? I'd moved the padding down a level in the markup so the hover/focus rule would include it, but in retrospect I should've just moved the hover/focus rule up a level.

[coveralls]

Pull Request Test Coverage Report for Build 9486263617

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 98.653%

---

Totals
Change from base Build 9321167366:	0.0%
Covered Lines:	586
Relevant Lines:	594

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9486301291

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 98.653%

---

Totals
Change from base Build 9321167366:	0.0%
Covered Lines:	586
Relevant Lines:	594

---

💛 - Coveralls

[jazairi]

Leaving this open until it passes QA.

[coveralls]

Pull Request Test Coverage Report for Build 9486735034

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.2%) to 98.485%

---

Files with Coverage Reduction	New Missed Lines	%
app/controllers/search_controller.rb	1	98.11%

Totals
Change from base Build 9321167366:	-0.2%
Covered Lines:	585
Relevant Lines:	594

---

💛 - Coveralls

[jazairi]

Approved by UXWS this morning. Merging now.