Enable fake auth for new staging app #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: We have a temporary staging app, `thesis-submit-staging-new`, that we will use to test the new S3 bucket and SQS queues in the AWS org. It doesn't make sense to set up this second staging app with Touchstone, so it's best to use fake auth for testing purposes. Relevant ticket(s): N/A. How this addresses that need: This allows the new staging app to use fake auth. Side effects of this change: We'll want to remove this feature once we're done testing. An inline comment reiterates this. Longer term, it may make sense to log an exception and crash the application if fake auth is attempted in prod. (This is the situation that the `app_name_pattern_match?` method is trying to prevent.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
We have a temporary staging app,
thesis-submit-staging-new, that we will use to test the new S3 bucket and SQS queues in the AWS org. It doesn't make sense to set up this second staging app with Touchstone, so it's best to use fake auth for testing purposes.Relevant ticket(s):
N/A.
How this addresses that need:
This allows the new staging app to use fake auth.
Side effects of this change:
We'll want to remove this feature once we're done testing. An inline comment reiterates this. Longer term, it may make sense to log an exception and crash the application if fake auth is attempted in prod. (This is the situation that the
app_name_pattern_match?method is trying to prevent.)Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO