Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code style #440

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Fix code style #440

merged 2 commits into from
Jan 25, 2023

Conversation

bemoody
Copy link
Collaborator

@bemoody bemoody commented Jan 25, 2023

We decided a while ago to require code in this project to be formatted using black.

Fix the style of edf.py accordingly. Require correct formatting for future pull requests.

Benjamin Moody added 2 commits January 25, 2023 13:02
If all code is supposed to be formatted according to black, we want to
check this and fail if any code is not formatted correctly.

Simply running "black ." here doesn't help, as that simply rewrites
any incorrectly-formatted files and exits with status 0.  Instead, run
with --check (fail if files are wrongly formatted) and --diff (print
differences to standard output).
Copy link
Member

@tompollard tompollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tompollard tompollard merged commit e8ec6b0 into main Jan 25, 2023
@tompollard tompollard deleted the style branch January 25, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants