When reading edf, decode all strings using 'iso8859-1'. #429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The edf specifications notes all strings being 'ascii'.
By default,
decode()
uses the 'utf-8' encoding. In some cases, this can cause decoding issues:Arguably, the encoding
ascii
should be used. However, in my case, this didn't completely solve the problem:Using the admittedly peculiar
unicode_escape
encoding solved the problem for me. Using the verbose printing mode, the culprit can be seen (µ
):Physical Dimensions: ['', 'mV', 'mV', 'mV', 'mV', 'mV', 'mV.s', 'µV', 'mV', 'mV.s', 'µV', '', 's', '', '', 'V']
The file in question was produced by LabView. Unfortunately, I cannot share it. If need be, it might be possible to reproduce the error otherwise.