Move content to new header.py. #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working to replace
_header.pywith a newheader.pymodule. Both need to exist together as long as the old (current)RecordAPI exists. All effort is going to be directed towardsheader.pyand the new APIs from now.This PR moves some of the useful content over to the new module, in order to keep as little (legacy-only) code in
_header.pyas possible, until it is eventually deleted.This also changes the time/date params of
csv_to_wfdbso that it stops trying to parse date/time strings. (I know that this is technically a breaking public API change but this is a very peripheral function)